Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Node v18.16.0 #515

Merged
merged 6 commits into from
May 8, 2023
Merged

Update to Node v18.16.0 #515

merged 6 commits into from
May 8, 2023

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented May 8, 2023

No description provided.

@mcollina
Update to Node v18.16.0
520712b 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina requested review from benjamingr and ronag May 8, 2023 09:47
@mcollina
fixup
e41f84c 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
fixup
fbb1f4c 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
fixupo
5578723 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
fixup
ba9a5f5 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
Copy link
Member Author

mcollina commented May 8, 2023

cc @ShogunPanda

ShogunPanda
ShogunPanda approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Make sure you run npm run format (or similar, can't check the code now) as I see some file with unneeded changes.

@mcollina
format
15b71e9 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina merged commit b345071 into main May 8, 2023
@mcollina mcollina deleted the update branch May 8, 2023 16:12
@WontonSam WontonSam mentioned this pull request Jul 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@ronag ronag ronag approved these changes

@benjamingr benjamingr Awaiting requested review from benjamingr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcollina @ShogunPanda @ronag