This repository has been archived by the owner on May 13, 2019. It is now read-only.
src: reduce patches required to build coverage #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have the --coverage option landed in core we can remove some of the patches for node.gyp
cjihrig
approved these changes
Nov 9, 2016
mhdawson
added a commit
that referenced
this pull request
Nov 9, 2016
Now that we have the --coverage option landed in core we can remove some of the patches for node.gyp PR-URL: #40 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed as 387677c |
maclover7
pushed a commit
to maclover7/build
that referenced
this pull request
Dec 31, 2017
Now that we have the --coverage option landed in core we can remove some of the patches for node.gyp PR-URL: nodejs/testing#40 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the --coverage option landed in
core we can remove some of the patches for node.gyp