skip bundle test on node 16 (#2377)

* skip bundle test on node 16 * skip more tests * fix
nodejs · Oct 25, 2023 · 3ec35ee · 3ec35ee
1 parent 67e714d
commit 3ec35ee
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 4 deletions.
diff --git a/test/fetch/bundle.js b/test/fetch/bundle.js
@@ -1,6 +1,13 @@
 'use strict'
 
-const { test } = require('tap')
+const { test, skip } = require('tap')
+const { nodeMajor } = require('../../lib/core/util')
+
+if (nodeMajor === 16) {
+  skip('esbuild uses static blocks with --keep-names which node 16.8 does not have')
+  process.exit()
+}
+
 const { Response, Request, FormData, Headers } = require('../../undici-fetch')
 
 test('bundle sets constructor.name and .name properly', (t) => {

diff --git a/test/fetch/client-node-max-header-size.js b/test/fetch/client-node-max-header-size.js
@@ -1,7 +1,13 @@
 'use strict'
 
 const { execSync } = require('node:child_process')
-const { test } = require('tap')
+const { test, skip } = require('tap')
+const { nodeMajor } = require('../../lib/core/util')
+
+if (nodeMajor === 16) {
+  skip('esbuild uses static blocks with --keep-names which node 16.8 does not have')
+  process.exit()
+}
 
 const command = 'node -e "require(\'./undici-fetch.js\').fetch(\'https://httpbin.org/get\')"'
 

diff --git a/test/fetch/issue-1447.js b/test/fetch/issue-1447.js
@@ -1,6 +1,12 @@
 'use strict'
 
-const { test } = require('tap')
+const { test, skip } = require('tap')
+const { nodeMajor } = require('../../lib/core/util')
+
+if (nodeMajor === 16) {
+  skip('esbuild uses static blocks with --keep-names which node 16.8 does not have')
+  process.exit()
+}
 
 const undici = require('../..')
 const { fetch: theoreticalGlobalFetch } = require('../../undici-fetch')

diff --git a/test/fetch/user-agent.js b/test/fetch/user-agent.js
@@ -1,9 +1,16 @@
 'use strict'
 
-const { test } = require('tap')
+const { test, skip } = require('tap')
 const events = require('events')
 const http = require('http')
 const undici = require('../../')
+const { nodeMajor } = require('../../lib/core/util')
+
+if (nodeMajor === 16) {
+  skip('esbuild uses static blocks with --keep-names which node 16.8 does not have')
+  process.exit()
+}
+
 const nodeBuild = require('../../undici-fetch.js')
 
 test('user-agent defaults correctly', async (t) => {