abort might not work

[ronag]

Reviewing abort and looking at some services in production I believe aborting requests might not fully work, i.e. the socket is not killed.

[ronag]

Actually this might be working as design. An aborted requests that is not in the head of the pipeline will wait for the first head to finish before killing the socket.

[mcollina]

Actually this might be working as design. An aborted requests that is not in the head of the pipeline will wait for the first head to finish before killing the socket.

I agree

[ronag]

I'm still seeing leaking connections in production. Not sure if user or undici error. Trying to bypass undici Pool and Agent and just use Client with a simpler Pool/Agent logic to see if that makes any difference.

[ronag]

That made things a lot better. I suspect we have some form of edge case issue in undici. I will do an in depth review and see if I can add more tests.

[ronag]

@mcollina @dnlup I think this is a blocker for v4 release. I haven't been able to reproduce it outside of production system.

I guess our only choice is to do in depth review and see if we can find any path that could cause this.

I'm probably most familiar with this logic and will focus on this.

[ronag]

Actually this might be working as design. An aborted requests that is not in the head of the pipeline will wait for the first head to finish before killing the socket.

I agree

There is a possibility of a deadlock here if the first request is waiting for the aborted second request (pipelining > 1). It might be safer to just destroy the entire pipeline. @mcollina wdyt?

[mcollina]

There is a possibility of a deadlock here if the first request is waiting for the aborted second request (pipelining > 1). It might be safer to just destroy the entire pipeline.

Go for safety, but document this as a downside of pipelining.