fix(fetch): FormData.set empties this[kState] if k exists #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
reviewed
Sep 3, 2021
ronag
reviewed
Sep 3, 2021
ronag
reviewed
Sep 3, 2021
ronag
reviewed
Sep 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
+ Coverage 94.25% 94.59% +0.33%
==========================================
Files 37 37
Lines 3605 3605
==========================================
+ Hits 3398 3410 +12
+ Misses 207 195 -12
Continue to review full report at Codecov.
|
Co-authored-by: Robert Nagy <ronagy@icloud.com>
ronag
approved these changes
Sep 3, 2021
|
Thanks! |
szmarczak
approved these changes
Sep 3, 2021
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix(fetch): form.set() empties kState if k exists * test(fetch): improve coverage * fix(fetch): better performance of FormData.set() * fix(fetch): use ES6 syntax Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Robert Nagy <ronagy@icloud.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix(fetch): form.set() empties kState if k exists * test(fetch): improve coverage * fix(fetch): better performance of FormData.set() * fix(fetch): use ES6 syntax Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Robert Nagy <ronagy@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
FormData.set(k, v)will empty the entirethis[kState]ifkexists. This is not what it is supposed to do. Fix it.lib/fetch/formdata.js