Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve coverage for balanced-pool #1296

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Mar 20, 2022

This PR improves coverage for balanced-pool.

@ronag ronag requested a review from mcollina March 20, 2022 13:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #1296 (bf932bf) into main (6a0388f) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   94.03%   94.15%   +0.12%     
==========================================
  Files          44       44              
  Lines        4107     4107              
==========================================
+ Hits         3862     3867       +5     
+ Misses        245      240       -5     
Impacted Files Coverage Δ
lib/fetch/request.js 85.06% <0.00%> (-0.42%) ⬇️
lib/balanced-pool.js 100.00% <0.00%> (+2.38%) ⬆️
lib/core/errors.js 100.00% <0.00%> (+5.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a0388f...bf932bf. Read the comment docs.

@ronag ronag merged commit e10e2a6 into nodejs:main Mar 21, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants