Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clientFactory option to ProxyAgent #2003

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Add clientFactory option to ProxyAgent #2003

merged 3 commits into from
Mar 13, 2023

Commits on Mar 11, 2023

  1. Add clientFactory option to ProxyAgent 

    The default use of a Client means that HTTP CONNECT requests to the
Proxy will block successive requests. Giving consumers the option to
supply a factory allows them use a Pool which ensures that these
requests will not block.

fixes: nodejs#2001
    @andrewfecenko2
    andrewfecenko2 committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    480c2f6 View commit details
    Browse the repository at this point in the history

  2. fixup! Use pool by default and change clientFactory return type

    @andrewfecenko2
    andrewfecenko2 committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    9f3e0aa View commit details
    Browse the repository at this point in the history

  3. Add clientFactory to ProxyAgent docs

    @andrewfecenko2
    andrewfecenko2 committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    0926552 View commit details
    Browse the repository at this point in the history