Further automate publishing of undici-types using GitHub Actions workflow #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 25, 2023 14:18
ronag
approved these changes
Sep 25, 2023
|
Before we merge I need the token added. Otherwise it won't work. Let me know who has these permissions so I can get it set up. Thanks! |
@Ethan-Arrowood you are marked as an owner to this repo, you should be able to set the secret. |
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
…flow (nodejs#2290) * add workflow * improve automation * linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands on my previous PR of automating the publish of
undici-typesto use GitHub Actions workflow. It should trigger anytime we push a tag likev5.25.2. This will then checkout the repo, runnpm ci, generate a package.json file based on the one in root, and then runnpm publishwith the correct auth permissionsTODO:
NPM_TOKENto repo secrets. I have one generated already I need someone with repo admin privileges to help me get it added.