Update chunksDecode

[ValchanOficial]

From this bug: 2854

[ronag]

This looks wrong to me. But maybe someone else disagrees.

[Uzlopak]

This does not make any sense. Also why would we need to call JSON.stringify all the time as JSON.stringify('') is equal to '""'.

So why do we need here two double quotes?

[Uzlopak]

Makes no sense

[ValchanOficial]

Try: https://developer.mozilla.org/pt-BR/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse

[ValchanOficial]

Line 306: resolve(JSON.parse(chunksDecode(body, length)))
chunksDecode returns ''
But JSON.parse('') doesn't work as expected

[ValchanOficial]

https://github.com/ValchanOficial/example

[ValchanOficial]

Using return ''

Using return JSON.stringify('')

[ValchanOficial]

@ronag @Uzlopak could you please take a look?

[ronag]

We understand what you are trying to do and we don't think it's a good idea. If we try to decode an empty string we think it should error.

[ValchanOficial]

We understand what you are trying to do and we don't think it's a good idea. If we try to decode an empty string we think it should error.

Shouldn't it return at least 204 then?

[ronag]

Who? The server? That's out of our control...

[ValchanOficial]

If the person calls an external API they do not have control of the body.
Why not make the lives of those who use the lib easier?

[Uzlopak]

The problem is that you are not describing the error properly.

Your bug report is actually:

An endpoint returns an empty string as payload. Fetch against this endpoint is successful. Calling body.text() returns an empty string as expected. Calling body.json() returns in an error, because an empty string can not be parsed successfully.

The question is, is throwing an error correct?
What does e.g. fetch return in chrome? Does it throw? Does it return null or undefined?
Do we have to encapsulate the JSON parse error and throw a fetch specific error?

[Uzlopak]

I investigated this and this is definetly working as expected.

[ValchanOficial]

Do we have to encapsulate the JSON parse error and throw a fetch specific error?

Maybe just return body without parse it

[Uzlopak]

No.

[ronag]

We follow the body mixin spec on this. Which is what our users expect.

https://developer.mozilla.org/en-US/docs/Web/API/Request/json

https://fetch.spec.whatwg.org/#ref-for-dom-body-json%E2%91%A0