fix: parseHeaders should take Record<string, ...> #3244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
parse.headers
branch
5 times, most recently
from
c2207cf
to
c5d4379
Compare
mcollina
reviewed
May 11, 2024
Uzlopak
reviewed
May 11, 2024
It's fixing so that the function does what the types say. Since we export this function it's important that it's correct. |
ronag
added a commit
to nxtedition/nxt-undici
that referenced
this pull request
May 12, 2024
ronag
added a commit
to nxtedition/nxt-undici
that referenced
this pull request
May 12, 2024
|
Added in nxt-undici for now. If someone wants to makes tests feel free to take over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status