-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websocket: optimize masking using WebAssembly #3273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: delete this file
Autobahn Test ReportSummary
Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right way for WebSocket to move in.
closed/ |
@lpinca I'm not sure if you'd be interested in this or not. |
It is nice for portability but |
Since it must be copied to the memory area, bufferutil, which does not copy, has the advantage. |
@lpinca Can you provide the specification for the functions? |
@lemire for a possible API see https://github.com/websockets/bufferutil?tab=readme-ov-file#bufferutilmasksource-mask-output-offset-length. The last 3 parameters can be optional. |
@lpinca @KhafraDev Thanks. |
Closes #3265
https://github.com/tsctx/ws-masking
Script: https://github.com/nodejs/undici/blob/e0e786fabdd5063fb3986495a4bcdb82b5af5e0d/benchmarks/websocket/websocket-send-buffer.mjs