fix: Include final URL in redirect history. #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
=======================================
Coverage 94.02% 94.03%
=======================================
Files 37 37
Lines 3583 3587 +4
=======================================
+ Hits 3369 3373 +4
Misses 214 214
Continue to review full report at Codecov.
|
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, a URL is added to
context.historyonly if in the response there is a redirect to follow.Unfortunately, this results in the final URL of the redirects chain to never be present in the history and apparently there are no other ways to get such URL.
This PR fixes this problem by appending each URL visited. In case of no redirections, the
context.historywill contain just one element.Hope this helps!