Adding no-build logic for x64-usdt target if node version > 18 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Apr 8, 2024
recipes/x64-usdt/run.sh
Outdated
Comment on lines
24
to
28
| if [ $MAJOR_VERSION -ge 19 ]; then | ||
| echo 'dtrace support was removed in nodejs v19+ ... exiting' | ||
| exit 0 | ||
| fi | ||
|
|
There was a problem hiding this comment.
Bail logic usually goes in should-build.sh -- see other recipes for examples
unofficial-builds/bin/build.sh
Lines 113 to 119 in cb0e4ae
There was a problem hiding this comment.
Noted and affected per recommendation
scosol
changed the title
richardlau
approved these changes
Apr 8, 2024
|
thanks again @scosol, you're welcome to add yourself to the README if you like too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node19+ removed dtrace support, thus there is no point/ability to build this target for these versions.