Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not use mirrorlist for centos:7 builds. #149

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jwalton
Copy link
Contributor

@jwalton jwalton commented Jul 10, 2024

Fixes #147.

All the centos:7 builds are failing because the mirrorlist for centos repos has removed CentOS 7. This fixes this by modifying the yum repo config files so we fetch repos from valut.centos.org instead of from the mirrorlist URLs.

Tried this out with x64-glibc-217 and made sure it built successfully. I also tried x64-pointer-compression and stopped it before it completed, but made sure it got into the compilation phase (it won't get anywhere near that far without this fix).

@jwalton jwalton marked this pull request as ready for review July 10, 2024 15:30
@rvagg rvagg merged commit 40a7198 into nodejs:main Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

centos:7 builds are failing
3 participants