Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mute word audio on matching until matched (configurable) #482

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

toshify
Copy link
Collaborator

@toshify toshify commented Apr 9, 2024

Because providing audio on words in matching exercises makes it too tempting to just rely on the audio of a word instead of spending the necessary energy to recall meaning, we need to mute audio from words in matching exercises until a word and a picture/symbol (with audio) has been matched.

After a match, the audio should reinforce memorization with context and possibly also feel like a reward.

If the audio on the word is available before a match has been achieved, it may bee too tempting to just listen to the audio of the word and not spend effort recalling the meaning of the word from memory, and therefore gain much less memory retention training from the matching exercise.

We make this new feature configurable by content developers, so that this feature can be turned on and off on a unit by unit basis.

This commit will:

  • mute audio on words in matching exercises if the word has not yet been matched to a picture/symbol and also the unit has NOT been configured by a content developer to override muting (i.e. the default will be to mute)

Certification

  • I certify that
  • I have read the contributing guidelines
  • I license these contributions to the public under Seedlingo's LICENSE and have the rights to do so.

@toshify toshify force-pushed the feat/toggle-matching-audio branch from 20ed4c1 to c140ea5 Compare April 9, 2024 13:13
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-482.dheqk4e07yyd1.amplifyapp.com

@toshify toshify force-pushed the feat/toggle-matching-audio branch 3 times, most recently from 6aea378 to 2471f8b Compare April 12, 2024 00:31
Because providing audio on words in matching exercises
makes it too tempting to just rely on the audio of a word
instead of spending the necessary energy to recall meaning,
we need to mute audio from words in matching exercises
until a word and a picture/symbol (with audio) has been matched.

After a match, the audio should reinforce memorization with context
and possibly also feel like a reward.

If the audio on the word is available before a match has been achieved,
it may bee too tempting to just listen to the audio of the word
and not spend effort recalling the meaning of the word from memory,
and therefore gain much less memory retention training
from the matching exercise.

We make this new feature configurable by content developers,
so that this feature can be turned on and off on a unit by unit basis.

This commit will:
- mute audio on words in matching exercises
  if the word has not yet been matched to a picture/symbol
  and also the unit has NOT been configured by a content developer
  to override muting (i.e. the default will be to mute)

**Certification**
- [X] I certify that <!-- Check the box to certify: [X] -->
- I have read the [contributing guidelines](
  https://github.com/nodepa/seedlingo/blob/main/.github/CONTRIBUTING.md)
- I license these contributions to the public under Seedlingo's
  [LICENSE](https://github.com/nodepa/seedlingo/blob/main/LICENSE.md)
  and have the rights to do so.

Signed-off-by: toshify <4579559+toshify@users.noreply.github.com>
@toshify toshify merged commit 331701c into nodepa:main Apr 12, 2024
3 checks passed
@toshify toshify deleted the feat/toggle-matching-audio branch April 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant