You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
@Kawacrepe Yes, I want to make sure I understood the task correctly. This is effectively removing the temp.js file after carefully transposing its logic into a unit test. In conclusion, should we also implement Rossbob's recommendations
Our tests must be refacto, we must execute
temp.js
to create the nsecure-result.json which will be analyzed by the package.We want to remove this file and include the step in our tests.
The second improvement consist in what Rossbob told me in another PR
I would have added some tests over rewriting it :
but it may be overkill
Originally posted by @Rossb0b in #12 (review)
The text was updated successfully, but these errors were encountered: