Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: initial draft of cross-platform section #7

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

mhdawson
Copy link
Contributor

@mhdawson mhdawson commented Dec 7, 2023

No description provided.

mhdawson and others added 3 commits December 7, 2023 11:58
Signed-off-by: Michael Dawson <midawson@redhat.com>
Signed-off-by: Michael Dawson <midawson@redhat.com>
Copy link

@jimlindeman jimlindeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is confusing Operating System platform (Linux, MacOS, Windows, iOS, Android) with architecture platform (amd64, arm64, ppc64le, etc). Be aware that nodejs code can be independent of both of those parameters, but Dockerfiles will be specific to a single OS, but can then be built against multiple cpu platforms.

For example, a RedHat UBI9 container for a nodejs application can be built for arm64 (M1 Macs) and amd64 (aka x86_64), with the same Dockerfile as input. Note, the docker architecture then allows definition of a manifest layer that then redirects the appropriate architecture platform image to be downloaded based on the client architecture. That is why a FROM in a Dockerfile doesn't have to specify the architecture platform, like "FROM registry.access.redhat.com/ubi9/nodejs-20:latest".

@lholmquist
Copy link
Member

I wonder if this is confusing Operating System platform (Linux, MacOS, Windows, iOS, Android) with architecture platform (amd64, arm64, ppc64le, etc). Be aware that nodejs code can be independent of both of those parameters, but Dockerfiles will be specific to a single OS, but can then be built against multiple cpu platforms.

My understanding is that since this repo is more front-end related, that we would be discussing the platforms that a user interacts with, like iOS/Androind/Web and not necessarily the architecture, which we could/should probably discuss in the node.js reference architecture, if we haven't already

Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
@lholmquist lholmquist merged commit 44fcd39 into nodeshift:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants