Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #579 - If I accidentally select the wrong conference for a submission, I'd like to be able to change it. #580

Conversation

hilarysk
Copy link
Contributor

@hilarysk hilarysk commented May 8, 2024

What does this PR do?

This pull request includes changes to the submissions_controller.rb and submissions/edit.html.erb files. The changes allow for the selection of an event instance when editing a submission and modify the way the proposal title and event instance are displayed.

Changes in detail:

  • app/controllers/submissions_controller.rb: Added a line of code in the edit method to fetch all events ordered by name in ascending order. This provides the necessary data for the event instance selection in the edit submission form.
  • app/views/submissions/edit.html.erb: Modified the display of the proposal title and event instance in the paragraph tag. Added a grouped collection select form helper to allow the selection of an event instance when editing a submission.
Why was this work done? Is there a related Issue?

Issue #579

Where should a reviewer start?

Probably in the view

Are there any manual testing steps?

Visit the "edit submission" page

Screenshots

edit-submission.mp4

Deployment instructions

N/A

Database changes

N/A

New ENV variables

N/A

hilarysk and others added 2 commits May 8, 2024 16:27
…r a submission, I'd like to be able to change it.
…t-the-wrong-conference-for-a-submission-Id-like-to-be-able-to-change-it
@nodunayo
Copy link
Owner

Thanks for the video! :-D

@nodunayo nodunayo merged commit 1f6d2ee into nodunayo:master May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants