-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nested featherlight (up to 4) #25
Conversation
@noelboss This solution is kind of a hack, but it works pretty well. Are you ok with it, or would it be better to do this in JS? |
I am not a fan of z-indexes (especial high ones). If the ligthboxes are placed correctly at the bottom (which I think they are not) of the page its generally not necessary to set an index. I would rather not do this this since I want the author to understand the z-index structure of his page and make specific changes if needed. Also, not everyone needs that feature and it can easily be documented in the wiki. |
I don't think that's true. How about we support 2 levels out of the box, wiki if anyone needs more? |
Not true what I said. uses z-index :) sorry |
…screen instead of the top. We could still add a z-index to make it more compatible with pages that have a positioned and z-indexed element as a direkt child from body.
Can you test this with your nested setup? |
Oh, that works, nice. I still have to learn stuff about CSS. In my project I'll still use a z-index to insure that they float above anything else. To be nicer, only the last @noelboss Do we have an officially supported browser list? It would probably be nicer to support IE8-, so a oneliner in jQuery can handle that I guess |
@marcandre no list yet. I think it works at least ie8+ (don't have my vm's with me to test right now) (Edit: Have my IE8 VM... Generally works, but Icons look shitty (close, next, previous – not supported charakters, at least on my machine) and rgba for backgrounds in the gallery doesn't work either.) |
BTW, IE8 should work anyways since the background is not transparent there... |
Right, What I'm proposing is to remove the background color from the general I think there are JS libs to add support for that in IE8, so maybe we could decide they are needed for IE8-? |
Nice. |
I didn't think of this, but if any JS adds anything in the dom after the dialog has opened, even hidden things, then the background disappears altogether 😦 I have such a case here and can probably work around it, but I was thinking maybe we could bunch all |
Easy CSS solution to allow nested dialogs.