-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turned featherlight.js into UMD module #377
Conversation
Now we can use it in ES6 code like `import 'featherlight';` and it will not say there's no jQuery if you use webpack. No code inside Featherlight itself was changed, just wrapped into UMD loader.
Turned featherlight.js into UMD module
Thanks for the PR! |
featherlight.gallery turned to UMD just like featherlight.js NB: in release minified scripts are not changed.
Hi @marcandre I've wrapped featherllight.gallery in UMD as well for convenience. |
Hope the PR can be merged soon! Would be great use it as UMD module. |
Any status update on this? Edit: I can confirm that this pull request works. The minified files needs to be rebuild of course |
Thanks for the ping! |
Hi all,
|
anyone, any idea? |
Now we can use it in ES6 code like import 'featherlight'; and it will not say there's no jQuery if you use webpack.
No code inside Featherlight itself was changed, just wrapped into UMD loader.