Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turned featherlight.js into UMD module #377

Merged
merged 3 commits into from
Aug 21, 2019
Merged

Conversation

MikhailRoot
Copy link
Contributor

Now we can use it in ES6 code like import 'featherlight'; and it will not say there's no jQuery if you use webpack.
No code inside Featherlight itself was changed, just wrapped into UMD loader.

Now we can use it in ES6 code like `import 'featherlight';` and it will not say there's no jQuery if you use webpack.
No code inside Featherlight itself was changed, just wrapped into UMD loader.
Turned featherlight.js into UMD module
@MikhailRoot MikhailRoot mentioned this pull request Jan 17, 2019
@marcandre
Copy link
Collaborator

Thanks for the PR!
Please note that I'm currently travelling, so I probably won't be able to check this out as quickly as I'd like, but I will.

featherlight.gallery turned to UMD just like featherlight.js 
NB: in release minified scripts are not changed.
@MikhailRoot
Copy link
Contributor Author

Hi @marcandre I've wrapped featherllight.gallery in UMD as well for convenience.
NB: minified js files in /release are not recompiled. i've changed just sources.

@baezor
Copy link

baezor commented Jan 31, 2019

Hope the PR can be merged soon! Would be great use it as UMD module.

@jontro
Copy link

jontro commented Aug 20, 2019

Any status update on this? Edit: I can confirm that this pull request works. The minified files needs to be rebuild of course

@marcandre marcandre merged commit 4990ac9 into noelboss:master Aug 21, 2019
@marcandre
Copy link
Collaborator

marcandre commented Aug 21, 2019

Thanks for the ping!
Merged and released. Thanks for the great PR.

@Coysh
Copy link

Coysh commented Nov 11, 2021

Hi all,
Wondering how the gallery works?

import featherlight from 'featherlight'; seems to work for me - but I can't figure out how to import the gallery.

@jamaluddinrumi
Copy link

Hi all, Wondering how the gallery works?

import featherlight from 'featherlight'; seems to work for me - but I can't figure out how to import the gallery.

anyone, any idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants