-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Ignore NBT option #47
Comments
Are you using the default bingos or custom ones? And if you have custom bingos, could you send the game definitions please? |
The bug happened on the default one too (one of my streamer friend did an event and encountered the problem) Here was the original custom I made (On the very next version I changed the broken ones to stats as a temporary bypass) |
So the check fails to account for durability Edit: I would say that you should add "ignore nbt" option for task so this issue is fixed Edit 2 : During the mean time, since now I know how Java work, I'll try to fix the original issue myself and do a PR Edit 3 : PR in question : #57 |
Better optimisation and also found the TRUE issue, tho it has one problem Also fully fixes noeppi-noeppi#47
Bongo only consider items that has an identical NBT, this include no-NBT
Because of that, items that can have NBT data inside of them will become invalid for completion, this include :
Potions
Tools/Armor that aren't full durability or that has enchants
Filled Maps
Written Books
Fish/Axolotl Buckets
Named Item
Banners
Adding a "Ignore NBT" condition would fix this problem
Here is an exemple (while it is custom, it happens on non-modified bongo)
In this case, I have a stone axe, but since it lost 1 durability, it won't count
Edit: Reformated my message
The text was updated successfully, but these errors were encountered: