Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Ignore NBT option #47

Closed
TBiscuit1 opened this issue Feb 21, 2022 · 3 comments
Closed

Add an Ignore NBT option #47

TBiscuit1 opened this issue Feb 21, 2022 · 3 comments

Comments

@TBiscuit1
Copy link

TBiscuit1 commented Feb 21, 2022

Bongo only consider items that has an identical NBT, this include no-NBT

Because of that, items that can have NBT data inside of them will become invalid for completion, this include :

Potions
Tools/Armor that aren't full durability or that has enchants
Filled Maps
Written Books
Fish/Axolotl Buckets
Named Item
Banners

Adding a "Ignore NBT" condition would fix this problem

Here is an exemple (while it is custom, it happens on non-modified bongo)
image
In this case, I have a stone axe, but since it lost 1 durability, it won't count

Edit: Reformated my message

@noeppi-noeppi
Copy link
Owner

Are you using the default bingos or custom ones? And if you have custom bingos, could you send the game definitions please?

@TBiscuit1
Copy link
Author

The bug happened on the default one too (one of my streamer friend did an event and encountered the problem)
I remember someone not being able to complete a task because their shield had lost durability (they found someone else's shield)

Here was the original custom I made (On the very next version I changed the broken ones to stats as a temporary bypass)
Extra_Bingo.zip

@TBiscuit1 TBiscuit1 changed the title Items that has NBT data won't be counted Only item with the EXACT NBT are counted Jul 2, 2022
@TBiscuit1
Copy link
Author

TBiscuit1 commented Sep 6, 2022

image
I think I found the issue, you are checking if the tool are the same without the durability, but then check the nbt and that INCLUDE "Damage:Int" which is the durability

So the check fails to account for durability

Edit: I would say that you should add "ignore nbt" option for task so this issue is fixed

Edit 2 : During the mean time, since now I know how Java work, I'll try to fix the original issue myself and do a PR

Edit 3 : PR in question : #57

@TBiscuit1 TBiscuit1 changed the title Only item with the EXACT NBT are counted Add an Ignore NBT option and/or fix nbt and durability check Sep 6, 2022
@TBiscuit1 TBiscuit1 changed the title Add an Ignore NBT option and/or fix nbt and durability check Add an Ignore NBT option Sep 6, 2022
TBiscuit1 added a commit to TBiscuit1/Bongo that referenced this issue Sep 7, 2022
Better optimisation and also found the TRUE issue, tho it has one problem

Also fully fixes noeppi-noeppi#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants