Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking issues on Windows #122

Closed
wants to merge 3 commits into from
Closed

Conversation

searleser97
Copy link

@searleser97 searleser97 commented Dec 11, 2023

closes #77, #120

@noib3 noib3 changed the title Update README.md with linking instructions for windows Fix linking issues on Windows Dec 12, 2023
@noib3
Copy link
Owner

noib3 commented Dec 12, 2023

I've added those linker flags to the .cargo/config.toml file to see if it would fix CI on Windows.

Unfortunately all the integration tests fail because Neovim exited with non-zero exit code: -1073741819, which from what I call tell means that some access was denied.

Does the same happen to you locally if you do

cd tests
cargo build --features=neovim-nightly
cargo test --features=neovim-nightly

?

@searleser97
Copy link
Author

searleser97 commented Dec 12, 2023

I've added those linker flags to the .cargo/config.toml file to see if it would fix CI on Windows.

Unfortunately all the integration tests fail because Neovim exited with non-zero exit code: -1073741819, which from what I call tell means that some access was denied.

Does the same happen to you locally if you do

cd tests
cargo build --features=neovim-nightly
cargo test --features=neovim-nightly

?

Looks like I still need to add the build.rs mentioned in this comment to make it work. So, looks like we need to have a lua51.dll and lua.lib file at the time of testing in CI

@noib3
Copy link
Owner

noib3 commented Dec 12, 2023

So it works locally if you add that build.rs to tests? Seems weird since that's only relevant at build time, and building already works in CI.

@noib3
Copy link
Owner

noib3 commented Mar 10, 2024

Closed by #149.

@noib3 noib3 closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Requirements?
2 participants