Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move check_methods_signatures from dc_crate.rs into the type checker #3583

Closed
kevaundray opened this issue Nov 26, 2023 · 0 comments · Fixed by #4516
Closed

Move check_methods_signatures from dc_crate.rs into the type checker #3583

kevaundray opened this issue Nov 26, 2023 · 0 comments · Fixed by #4516
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kevaundray
Copy link
Contributor

Problem

This resolves the following TODO:

noir/compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs

Line 1056 in 70ccb7e

// TODO(vitkov): Move this out of here and into type_check

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request P-MEDIUM labels Nov 26, 2023
@kevaundray kevaundray added the good first issue Good for newcomers label Jan 15, 2024
@kevaundray kevaundray added this to the 0.25 milestone Jan 15, 2024
@Savio-Sou Savio-Sou removed this from the 0.25 milestone Feb 9, 2024
@jfecher jfecher mentioned this issue Mar 8, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 11, 2024
@jfecher
chore: Move check_method_signatures to type checking phase (#4516)
8d66677 
# Description

## Problem\*

Resolves #3583

## Summary\*

Resolves an old TODO by moving this function to the type checking phase.
I've rewritten the function since it was binding certain type variables
then unbound them afterward. I've changed that to substitute new
variables and only use `try_unify` to avoid accidentally binding
anything.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Move check_method_signatures to type checking phase noir-lang/noir
3 participants
@jfecher @kevaundray @Savio-Sou