Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error compiling the acir crate #405

Closed
ilitteri opened this issue Oct 24, 2022 · 2 comments
Closed

Error compiling the acir crate #405

ilitteri opened this issue Oct 24, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ilitteri
Copy link
Contributor

ilitteri commented Oct 24, 2022 •
edited
Loading

Description

Aim

To compile the acir crate.

Expected behavior

It should compile successfully for both bn254 and bls12_381 features (separately).

Bug

acvm is used and there is no way for the user to specify which feature to use causing a compilation error.

acvm has two features but none of them is specified in the Cargo.toml nor could be specified by the user in the terminal. Also acvm has no default feature.

I think that the default feature of acvm should be bn254 as it is in noir_fields and acir should inherit both features as well.

To reproduce

For some crates you have two different features for compilation both related to the elliptic curves used (bn254, bls12381). In those crates there is no default feature set and you should specify which to use or you are getting a compilation error (saying that you should use a feature).

  1. Clone the repo.
  2. cd crates/acir.
  3. cargo c or cargo c --features bn254 or cargo c --features bls12_381.

Environment

  • OS: macOS Monterey 12.6
@ilitteri ilitteri added the bug Something isn't working label Oct 24, 2022
ilitteri added a commit to lambdaclass/noir that referenced this issue Oct 24, 2022
@ilitteri
Update Cargo.toml
3412756 
This commit fixes noir-lang#405.

No compilation features were provided so the user is able to compile this crate successfully.

Now the user could compile with the bn254 feature or the bls12_381 feature.
@ilitteri ilitteri mentioned this issue Oct 24, 2022
Closed
5 tasks
@jfecher
Copy link
Contributor

jfecher commented Nov 1, 2022

What is the usecase for compiling the acir crate alone? Currently it should be setup such that compiling everything via nargo should work as expected.

@ilitteri
Copy link
Contributor Author

ilitteri commented Dec 9, 2022

See #406 closing comment.

@ilitteri ilitteri closed this as completed Dec 9, 2022
signorecello added a commit that referenced this issue Oct 17, 2023
@signorecello
closing #405 in the old docs repo, reference #3032
c4d63a2
signorecello added a commit that referenced this issue Oct 19, 2023
@signorecello
closing #405 in the old docs repo, reference #3032
76d3b53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error compiling the acir crate lambdaclass/noir
2 participants
@jfecher @ilitteri