-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(traits): Implement trait bounds def collector + resolver passes #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alexvitkov
force-pushed
the
trait-bounds-1
branch
from
September 18, 2023 12:34
5147546
to
d59c5db
Compare
8 tasks
alexvitkov
force-pushed
the
trait-bounds-1
branch
from
September 19, 2023 06:36
59f8922
to
c9f758c
Compare
alexvitkov
force-pushed
the
trait-bounds-1
branch
from
September 20, 2023 04:53
c9f758c
to
b8112da
Compare
jfecher
reviewed
Sep 20, 2023
jfecher
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since other PRs depend on this, I'll make my own PR to fix the small nits so that we can merge this one now.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be merged after #2652 - this PR also unfortunately includes the changes from that and the diff is currently quite ugly
Problem*
Summary*
Progress on #2568
This is the first part of a two-episode series on Trait Bounds. It turned out quite big, so I've split it into two - the next PR adds the type checker & monomorphizer for where clauses which is the majority of the work, this is some setup work that needs to get done in the early passes.
Changes:
find_trait_or_emit_error
which is helpful when walking over the where clauseTraitIds
to the UnresolvedTraitConstraintsDocumentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.