-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added doc-generator #3350
Conversation
I don’t think tokens are a good representation for generating documentation. Found a couple of issues: struct GrumpkinScalar {
low: Field,
high: Field,
} thread 'main' panicked at 'attempt to subtract with overflow', tooling/doc_generator/src/output.rs:164:58
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace It hangs with this code: // Map<V>
struct B<T_C> {}
impl<T_C> B<T_C> {
fn new(new_concrete_t_c_constructor: fn () -> T_C) -> B<T_C> {
B { new_concrete_t_c_constructor }
}
} /**/ It seems that the documentation lexer is implemented incorrectly in the fork. thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: UnterminatedBlockComment { span: Span(Span { start: ByteIndex(11), end: ByteIndex(13) }) }', tooling/doc_generator/src/getters.rs:455:45
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace trait MyTrait {
} thread 'main' panicked at 'attempt to subtract with overflow', tooling/doc_generator/src/getters.rs:304:29
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace it seems there are still a lot of problems, but yes |
@f01dab1e what is the status of this PR? |
@kevaundray, I think you can do a merge |
Before merging, can you check how this looks like on aztec-package contracts? If it doesn't work, then it makes sense to create a separate issue |
I wanted to share some feedback and issues I've encountered:
|
In an HTML file, the source code of a function is sometimes distorted or simply truncated. |
Looks like this is directly parsing Noir source code. This is going to add extra maintenance overhead on keeping this in sync with the main parser. I'd like to follow librustdoc and have the docs generated from the AST |
Description
Added generator of documentation pages for Noir lang.
Problem*
Resolves #3362
Summary*
With this documentation generator, you can create Rust doc-like documentation pages for Noir lang.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.