chore(ci): Fix publishing of ACVM crates #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
tf/fix-acvm-publishing
branch
from
878aec1
to
f922e4d
Compare
kevaundray
approved these changes
Nov 30, 2023
5 tasks
kevaundray
added a commit
that referenced
this pull request
Nov 30, 2023
# Description Continuation of #3645 ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
TomAFrench
added a commit
that referenced
this pull request
Dec 1, 2023
* master: (124 commits) chore: add env var for test updates in nargo_fmt (#3638) chore: remove unnecessary conversions from `add_constant` (#3651) feat: Complex slice inputs for dynamic slice builtins (#3617) feat: Add `FieldElement::from<usize>` implementation (#3647) chore: fix relative paths in reease please (#3646) chore: add integration test for verifying a recursive proof onchain (#3167) chore: adding docs to release please (#3571) chore(ci): Fix publishing of ACVM crates (#3645) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625) feat: Implement raw string literals (#3556) ...
TomAFrench
added a commit
that referenced
this pull request
Dec 1, 2023
* master: (28 commits) feat: reuse witnesses more when interacting with memory (#3658) chore(ci): stop committing new acir artifacts (#3654) chore: add env var for test updates in nargo_fmt (#3638) chore: remove unnecessary conversions from `add_constant` (#3651) feat: Complex slice inputs for dynamic slice builtins (#3617) feat: Add `FieldElement::from<usize>` implementation (#3647) chore: fix relative paths in reease please (#3646) chore: add integration test for verifying a recursive proof onchain (#3167) chore: adding docs to release please (#3571) chore(ci): Fix publishing of ACVM crates (#3645) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) ...
5 tasks
kevaundray
added a commit
that referenced
this pull request
Dec 1, 2023
# Description This reverts the versioning done in the root Cargo.toml [here](#3645) CI is currently complaining about this ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
5 tasks
kevaundray
added a commit
that referenced
this pull request
Dec 2, 2023
…dencies (#3673) # Description This reverts the change done in #3645 and removes the extraneous flake.nix file ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR does an "I reckon" fix to publishing ACVM crates.
I've added a version number to the workspace
Cargo.tomlso that these crates can be pushed to crates.io. The issue then is that we require these to be bumped appropriately by the release-please PR.I imagine the reason why this wasn't done originally is that it requires the
acvm-reporelease-please package to change files outside of its directory. I've given this a go however and we can check whether the PR gets updated correctly after this is merged.cc @kevaundray as he set up the original release please setup for ACVM.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.