chore: update bash script shebangs and dockerfiles #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a dual-list commit in both Noir and aztec repo. In this PR, Aztec gets the code to make a mirror, and the mirror action pushes to our `aztec` branch in Noir. The `aztec` branch features this as the first commit, to then be pushed one by one from master as Noir changes come in. --------- Co-authored-by: ludamad <adam@aztecprotocol.com>
This PR updates aztec-packages to use latest noir. - Regarding noir_wasm, providing the solved sources directly to `node_wasm` eliminates the need for `source-resolver`, which has been completely removed from the repository. - Added required pub in return values - Updated return_type - Pulled latest noir
TomAFrench
requested changes
Dec 19, 2023
TomAFrench
approved these changes
Dec 19, 2023
TomAFrench
changed the title
charlielye
reviewed
Dec 19, 2023
| @@ -14,7 +14,7 @@ process_dir() { | |||
| if [ -d ./target/ ]; then | |||
| rm -r ./target/ | |||
| fi | |||
| cargo run compile --only-acir && cargo run execute witness | |||
| nargo compile --only-acir && nargo execute witness | |||
There was a problem hiding this comment.
Hmmm. I made this change, but not sure if this is safe to bring back to noir. 🤔
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
# Description ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* This PR re-adds a change which was removed from #3875 which is required for the LSP to run inside of a docker container. ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development from Aztec.