Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update how-to-recursion.md #3912

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

brunny-eth
Copy link
Contributor

Last typo changes

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Last typo changes
@signorecello
Copy link
Contributor

Thanks Bruno, the CI is breaking though because the PR title should be something like chore: Update how-to recursion :)

(I can't fix it myself because you're not a contrib on this org... although you should )

@signorecello signorecello self-requested a review December 22, 2023 09:20
@kevaundray kevaundray changed the title Update how-to-recursion.md chore: Update how-to-recursion.md Dec 22, 2023
@signorecello
Copy link
Contributor

Oh wait Kev just did it 😆 probably I could too

Copy link
Contributor

@signorecello signorecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The labeling action is also failing now, I think it's something to do with perms

@signorecello signorecello added this pull request to the merge queue Dec 22, 2023
Merged via the queue into noir-lang:master with commit 8570a04 Dec 22, 2023
29 of 31 checks passed
TomAFrench added a commit that referenced this pull request Dec 28, 2023
* master:
  chore: Optimize goto_definitions for workspace case (#3914)
  chore: Update index.md (#3911)
  chore: Update index.md (#3910)
  chore: Update how-to-recursion.md (#3912)
  feat: Resolve oracle calls via JSON-RPC (#3902)
  chore: Update explainer-recursion.md (#3906)
  chore: remove unnecessary dependency (#3901)
  chore: improve package.json metadata (#3900)
  feat: prefer `AcirContext`-native methods for performing logic operations (#3898)
  feat: optimize logic gate ACIR-gen (#3897)
  fix: allow abi encoding tuples from JS (#3894)
  chore: error on cspell issues in docs (#3886)
TomAFrench added a commit that referenced this pull request Jan 3, 2024
* master: (48 commits)
  chore: fix broken links (#3935)
  chore: updated ACIR documentation and other docs (#3932)
  chore: rename "syntax" chapter in docs to "concepts" (#3934)
  fix: checks for cyclic dependencies (#3699)
  fix(debugger): crash when stepping through locations spanning multiple lines (#3920)
  chore: abstract away subtractions from `OR` implementation (#3923)
  chore: fix `should_fail_mismatch` test to use correct pedersen return type (#3927)
  fix: prevent `Instruction::Constrain`s for non-primitive types (#3916)
  feat: remove unnecessary predicate from `Lt` instruction (#3922)
  feat: simplify multiplications by `0` or `1` in ACIR gen (#3924)
  chore: bump dependency versions (#3925)
  chore: Update CONTRIBUTING.md (#3921)
  chore: Optimize goto_definitions for workspace case (#3914)
  chore: Update index.md (#3911)
  chore: Update index.md (#3910)
  chore: Update how-to-recursion.md (#3912)
  feat: Resolve oracle calls via JSON-RPC (#3902)
  chore: Update explainer-recursion.md (#3906)
  chore: remove unnecessary dependency (#3901)
  chore: improve package.json metadata (#3900)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants