chore: fix casing on InternalError::Unexpected
#3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
approved these changes
Jan 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TomAFrench
added a commit
that referenced
this pull request
Jan 3, 2024
TomAFrench
added a commit
that referenced
this pull request
Jan 4, 2024
* master: (30 commits) fix: handle multiple imports in the same file (#3903) feat: add foreign call support to `noir_codegen` functions (#3933) feat: Implement Operator Overloading (#3931) chore: fix casing on `InternalError::Unexpected` (#3937) chore: add test case for brillig array equality assertion (#3936) feat(lsp): goto struct member inside Impl method (#3918) chore: fix broken links (#3935) chore: updated ACIR documentation and other docs (#3932) chore: rename "syntax" chapter in docs to "concepts" (#3934) fix: checks for cyclic dependencies (#3699) fix(debugger): crash when stepping through locations spanning multiple lines (#3920) chore: abstract away subtractions from `OR` implementation (#3923) chore: fix `should_fail_mismatch` test to use correct pedersen return type (#3927) fix: prevent `Instruction::Constrain`s for non-primitive types (#3916) feat: remove unnecessary predicate from `Lt` instruction (#3922) feat: simplify multiplications by `0` or `1` in ACIR gen (#3924) chore: bump dependency versions (#3925) chore: Update CONTRIBUTING.md (#3921) chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) ...
TomAFrench
added a commit
that referenced
this pull request
Jan 5, 2024
* master: (137 commits) chore: add `insert_range_check` method to `FunctionBuilder` (#3959) chore: remove usage of term "preprocessed" in favour of "artifact" (#3939) feat(lsp): goto trait from trait impl (#3956) fix: preserve brillig entrypoint functions without arguments (#3951) feat: implement `Eq` trait on curve points (#3944) chore: fixing links to the blackbox functions (#3941) feat(lsp): cache definitions for goto requests (#3930) feat: remove range constraints from witnesses which are constrained to be constants (#3928) fix: implement missing codegen for `BlackBoxFunc::EcdsaSecp256r1` in brillig (#3943) chore(debugger): Integration tests (#3938) fix: handle multiple imports in the same file (#3903) feat: add foreign call support to `noir_codegen` functions (#3933) feat: Implement Operator Overloading (#3931) chore: fix casing on `InternalError::Unexpected` (#3937) chore: add test case for brillig array equality assertion (#3936) feat(lsp): goto struct member inside Impl method (#3918) chore: fix broken links (#3935) chore: updated ACIR documentation and other docs (#3932) chore: rename "syntax" chapter in docs to "concepts" (#3934) fix: checks for cyclic dependencies (#3699) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Unexpected is one word so we shouldn't have a capitial here.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.