Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from aztec-packages #4552

Closed
wants to merge 1 commit into from
Closed

feat: Sync from aztec-packages #4552

wants to merge 1 commit into from

Conversation

AztecBot
Copy link
Collaborator

Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
feat!: Support contracts with no constructor (AztecProtocol/aztec-packages#5175)
END_COMMIT_OVERRIDE

…kages#5175)

Changes:
- **Breaking**: `constructor` is no longer an enshrined function name,
it's now required to flag the constructor with `aztec(initializer)`.
- Remove need for a function named constructor in noir aztec-macros and
yarn-packages
- Add `isInitializer` flag to contract artifact
- Default the initializer to a function that has the
`aztec(initializer)` attribute, if there's more than one, pick one at
random, preferring private ones
- When there's no initializer, the `initializationHash` of a contract
instance is set to zero
- Remove empty constructor functions from our contracts, and flag public
constructors as initializer where missing

cc @AztecProtocol/devrel
@TomAFrench TomAFrench closed this Mar 14, 2024
Copy link
Contributor

Changes to circuit sizes

Generated at commit: fb83e55df946f9c3048b3bf7b4bab1838025364a, compared to commit: d4213a03c9f77ee8e7663fc965a825258d90a368

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
sha2_byte +573 ❌ +3.28% +193 ❌ +0.22%
regression_4449 -3,460 ✅ -49.88% -241,806 ✅ -86.14%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
sha2_byte 18,033 (+573) +3.28% 88,680 (+193) +0.22%
hashmap 219,609 (+338) +0.15% 492,103 (+338) +0.07%
regression_4449 3,477 (-3,460) -49.88% 38,904 (-241,806) -86.14%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants