Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backporting fixes from master #313

Closed
wants to merge 1 commit into from
Closed

Backporting fixes from master #313

wants to merge 1 commit into from

Conversation

gautvenk
Copy link
Contributor

#297
#305
#310
#312

Signed-off-by: Gautam Venkataramanan gautam.chennai@gmail.com

@gautvenk
Backporting fixes from master
50c1c3b 
#297
#305
#310
#312

Signed-off-by: Gautam Venkataramanan <gautam.chennai@gmail.com>
mchalla
mchalla approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@mchalla mchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine if you just cherry picked them. Not going through them in detail. My pull request to merge will have a merge conflict with these changes.

I am ok waiting on you to merge yours. I will resolve the conflict and resend after yours is merged.

@gautvenk
Copy link
Contributor Author

I think it looks fine if you just cherry picked them. Not going through them in detail. My pull request to merge will have a merge conflict with these changes.

I am ok waiting on you to merge yours. I will resolve the conflict and resend after yours is merged.

Thanks Madhu. Manually merged to avoid the mysterious issues of commits getting wiped off in the past.

@snaiksat
Copy link
Contributor

Hi Gautam, Can we please hold off on this.

@gautvenk
Copy link
Contributor Author

Hi Gautam, Can we please hold off on this.

Discussed with Sumit and Tom. Leaving the PR open for now. We will hold off on these.

@tomflynn
Copy link
Member

We're not backporting fixes to the jefferson branch any more. Closing this backport PR

@tomflynn tomflynn closed this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchalla mchalla mchalla approved these changes

@tomflynn tomflynn Awaiting requested review from tomflynn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gautvenk @snaiksat @tomflynn @mchalla