-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple network names and channel type #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgjs
reviewed
Jul 20, 2023
carlosgjs
reviewed
Jul 20, 2023
carlosgjs
requested changes
Jul 20, 2023
Co-authored-by: carlosgjs <carlosgjs@users.noreply.github.com>
niyiyu
force-pushed
the
niyiyu/pnwstore_multi_network
branch
from
July 20, 2023 01:03
1be485f
to
50801ad
Compare
carlosgjs
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion to cleanup the extra cell. Looks good!
Thanks for all of your comments. I will leave the switch of the frequency filter in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some small modifications to the PNWDataStore object. After the modification, the PNWDataStore object now supports:
See the updated tutorial (noisepy_pnwstore_tutorial.ipynb) for more information. We are doing more tests at this moment.