Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple network names and channel type #154

Merged
merged 9 commits into from
Jul 20, 2023

Conversation

niyiyu
Copy link
Collaborator

@niyiyu niyiyu commented Jul 19, 2023

This PR contains some small modifications to the PNWDataStore object. After the modification, the PNWDataStore object now supports:

  • channel filter for multiple channel types, e.g., loading HH,EH,BH at the same time
  • reading data from multiple network name, e.g., UW, UO, CC, at the same time. The later one is achieved straightforward by modifying DATA path: we replace hardcoded network name to "__", which is the wildcard in the sqlite grammar indicating any two chars.

See the updated tutorial (noisepy_pnwstore_tutorial.ipynb) for more information. We are doing more tests at this moment.

@niyiyu niyiyu temporarily deployed to github-pages July 19, 2023 22:31 — with GitHub Actions Inactive
@niyiyu niyiyu temporarily deployed to github-pages July 19, 2023 23:41 — with GitHub Actions Inactive
src/noisepy/seis/pnwstore.py Show resolved Hide resolved
tutorials/noisepy_pnwstore_tutorial.ipynb Outdated Show resolved Hide resolved
tutorials/noisepy_pnwstore_tutorial.ipynb Outdated Show resolved Hide resolved
src/noisepy/seis/plotting_modules.py Outdated Show resolved Hide resolved
tutorials/noisepy_pnwstore_tutorial.ipynb Outdated Show resolved Hide resolved
Co-authored-by: carlosgjs <carlosgjs@users.noreply.github.com>
@niyiyu niyiyu temporarily deployed to github-pages July 20, 2023 00:48 — with GitHub Actions Inactive
@niyiyu niyiyu temporarily deployed to github-pages July 20, 2023 00:55 — with GitHub Actions Inactive
@niyiyu niyiyu temporarily deployed to github-pages July 20, 2023 01:02 — with GitHub Actions Inactive
@niyiyu niyiyu force-pushed the niyiyu/pnwstore_multi_network branch from 1be485f to 50801ad Compare July 20, 2023 01:03
@niyiyu niyiyu temporarily deployed to github-pages July 20, 2023 01:11 — with GitHub Actions Inactive
Copy link
Collaborator

@carlosgjs carlosgjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion to cleanup the extra cell. Looks good!

src/noisepy/seis/pnwstore.py Show resolved Hide resolved
tutorials/noisepy_pnwstore_tutorial.ipynb Outdated Show resolved Hide resolved
@niyiyu niyiyu temporarily deployed to github-pages July 20, 2023 21:14 — with GitHub Actions Inactive
@niyiyu niyiyu marked this pull request as ready for review July 20, 2023 21:15
@niyiyu
Copy link
Collaborator Author

niyiyu commented Jul 20, 2023

Thanks for all of your comments. I will leave the switch of the frequency filter in another PR.

@niyiyu niyiyu merged commit 18edefd into master Jul 20, 2023
47 checks passed
@niyiyu niyiyu deleted the niyiyu/pnwstore_multi_network branch July 20, 2023 21:30
@niyiyu niyiyu restored the niyiyu/pnwstore_multi_network branch July 20, 2023 21:33
@niyiyu niyiyu deleted the niyiyu/pnwstore_multi_network branch July 20, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants