chore(views): Reimplement views using slices #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reimplemented views using a slice because I though the current implementation using an array of an arbitrary size could be better, especially because it was wasting space as a means to avoid a buffer overflow. I've also removed mutexes because this code is never called in a concurrent way and I don't see any reasons why it would be in the future.
Errors are now managed using
log.Fatalwhich I dislike because the program may exit without the error message being printed to the console, but it's used all over the place in NoiseTorch's source code. In the case of views, these errors should never happen, unless a programmer did something wrong in the UI code like mistakenly closing two views when there was only one existing.Again, any feedback welcome, even if nit-picky.