Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the usage as a Git submodule #61

Closed
ropinho opened this issue Jul 15, 2021 · 2 comments
Closed

Allow the usage as a Git submodule #61

ropinho opened this issue Jul 15, 2021 · 2 comments

Comments

@ropinho
Copy link
Contributor

ropinho commented Jul 15, 2021

Hi, I would like to use the ParadisEO as a Git submodule. I know that is possible to do it, but it requires more configuration.

In order to use ParadisEO as a Git submodule, would be interesting change the references to directory names in CMakeLists.txt files. When we try to configure all project with cmake, it tries configure the eo directory as [my-project-path]/eo instead some thing as [my-project-path]/external/paradiseo/eo.

(the path to submodule is external/paradiseo in this case).

Suggestion

The suggestion is replace the CMAKE_SOURCE_DIRs with CMAKE_CURRENT_SOURCE_DIR or PROJECT_SOURCE_DIR to cmake always configures these directories as relative path to the paradiseo repository path. This way, the following simple CMake code works:

add_subdirectory(external/paradiseo)
@nojhan
Copy link
Owner

nojhan commented Jul 15, 2021 via email

@nojhan
Copy link
Owner

nojhan commented Jul 21, 2021

Merged, thanks!

@nojhan nojhan closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants