Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating sr iov dp #50

Merged
merged 22 commits into from
Mar 5, 2019
Merged

Conversation

peterszilagyi
Copy link
Contributor

@peterszilagyi peterszilagyi commented Feb 25, 2019

What type of PR is this?

feature

What does this PR give to us:
DANM Integration with Intel SR-IOV Network Device Plugin and latest Intel SR-IOV CNI
Which issue(s) this PR fixes (in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

action required
*DanmNet definition's device_pool attribute should contain the SR IOV DP ResourceName 
* Pod definitions having sriov DanmNets should have SR-IOV DP resource requests too 

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/danm/danm.go Outdated Show resolved Hide resolved
pkg/glide.yaml Show resolved Hide resolved
pkg/danm/danm.go Show resolved Hide resolved
pkg/cnidel/cniconfs.go Outdated Show resolved Hide resolved
@Levovar
Copy link
Collaborator

Levovar commented Mar 1, 2019

Okay, logic is now super-duper.
One cosmetical, readability related comment left, and the ones from the first batch related to making the new struct parameters generic, deleting unneeded parameters from the schema, nad correcting documentation

let's also find out why netwatcher ignores your new param. you know that you use device_pool as the name of your attribute in your code, right? weren't you using "resource_pool" in your test examples?
that would explain why netwatcher can't parse it :)

@peterszilagyi
Copy link
Contributor Author

peterszilagyi commented Mar 1, 2019

Thanks for comments. Code related stuffs have been corrected. README.md update is going to be happened soon.

CRD issue: You're right, epic fail :/

schema/DanmNet.yaml Outdated Show resolved Hide resolved
schema/network_attach.yaml Outdated Show resolved Hide resolved
schema/DanmNet.yaml Outdated Show resolved Hide resolved
@Levovar
Copy link
Collaborator

Levovar commented Mar 5, 2019

So, all-in-all, thanks! I think it was a good journey :)
I'm fine with README and UTs arriving separately, let's not prolong this review anymore

@Levovar Levovar merged commit 71904e2 into nokia:master Mar 5, 2019
@peterszilagyi
Copy link
Contributor Author

I agree :) Thank you for driving me to reach this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants