DANM 4.0 EP4: Adding the TenantNetwork mutating code to the Webhook. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
force-pushed
the
tenantnet_setup
branch
2 times, most recently
from
7e50358
to
930c958
Compare
First, we need to create allocation bitarrays for every virtual interface when a TenantConfig is instantiated. Then, when a TenantNetwork comes we need to: - choose appropriate host_device, vlan, and vxlan IDs based on the configured TenantNetwork - reserve the chosen VNI for the interface - apply additional overwrites, such as NetworkType specific NetworkID Existing validation rules were also enhanced. We now allow the initial provisioning of host_device for TenantNetworks. If user added it, we only match it against the Tenantconfig, and chose the configured VNIs, if, any. We do the same for SR-IOV networks having DevicePools, instead of Devices. Validation rules were also updated to make sure SR-IOV networks get special attention.
Levovar
changed the title
This handler is responsible for handling DELETE events arriving for TenantNetworks. During each such occurences we need to inspect if the TN being deleted had anyi VNI automatically allocated. If yes, the VNI needs to be freed in the respective TenantConfig. This hook can be used later on to add delete specific checks for other network APIs as well, e.g. checking if Pods are still connected to a network being deleted etc.
Levovar
force-pushed
the
tenantnet_setup
branch
11 times, most recently
from
d6b4e6c
to
7a8ac09
Compare
Levovar
force-pushed
the
tenantnet_setup
branch
6 times, most recently
from
a04d225
to
2e718fa
Compare
1: There was a nil pointer reference error in metacni during creation of DANM client 2: IsDynamicBackend incorrectly did not recognize ipvlan as such 3: Accidentally used shallow copy was changed to a (manual, sigh) deep copy when we save the original manifest during net, and conf validation 4: HostDevices list was not properly patched. When changed, the whole JSON list is now put together, and sent for replacement 5: When a host_device or devicepool is explicitly requested, but is not configured, we throw a validation error 6: hostDevices are now filtered, so DevicePools are not accidentally randomly allocated as host_device for a TenantNetwork 7: Mutating VLAN and VxLAN types for accidentally switched up due to wrong condition 8: NetworkIDs were not mutated into the networks because we haven't checked whether they even changed 9: NEtworkID pre-validation was accidentally removed from ClusterNetwork, not from TenantNetwork :) DISCLAIMER: Freeing VNIs in TenantConfig does not work because K8s does not fill ANY Objects in DELETE requests!!! Fortunetaly correction is merged, but we need to wait for 1.15. Til then - no freeing of VNIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the other reviews did not make sense until now this should clear it up.
PR takes care of assigning environment specific network information to TenantNetworks based on the TenantConfig API.
Because you don't control your VLANs: netadmins do!