DANM 4.0 EP6: Adapting CNI code to work with all the APIs #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
changed the title
Fixed various comments still referring exclusively to DanmNet, or to old structure. TypeMeta is not sent by K8s API server, so we need to manually set TypeMeta.Kind into the objects. Fixed an issue during deletion which resulted in DanmEps leaking when the network could not be interrogated.
Levovar
force-pushed
the
metacni_fourdoto
branch
from
584a148
to
f658e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires basically changing the code which deals with the external interfaces -both uplink and downlink-, but does not require us to re-write everything.
We only need to convert everything to DanmNet type, then the internals continue to work as-is.
Refactoring happened where it was absolutely required, for example in the handling of the annotation, and the default networks.
The code generally only got better.