Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting stuff to work with cognito #181

Closed
wants to merge 4 commits into from
Closed

Adjusting stuff to work with cognito #181

wants to merge 4 commits into from

Conversation

ledbruno
Copy link

@ledbruno ledbruno commented Oct 15, 2020 •
edited
Loading

  1. Lua resty/oidc need some configurations (redirect uri and scheme)... so we pass this through the shared config
  2. Some injected header are too big when working with cognito and useless for our case. Now we can config which headers are injected and sent to the upstream service

This PR should be merged as well, so all things will "work"
zmartzone/lua-resty-openidc#363

igorbrites
igorbrites approved these changes Oct 15, 2020
View reviewed changes
Copy link

@igorbrites igorbrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ledbruno ledbruno mentioned this pull request Oct 21, 2020
Open
@ledbruno ledbruno closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbrites igorbrites igorbrites approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ledbruno @igorbrites