Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new environment implementation #250

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

5nord
Copy link
Member

@5nord 5nord commented Aug 6, 2021

This commit replaces our custom environment handling implementation with
a port of the better known dotenv project.
It also introduces some breaking changes:

  • ntt.env is evaluated before k3.env
  • NTT_ prefix has a higher precedence than K3_ prefix
  • all variables have to be defined up-front
  • all unknown environment variables will be replaced with ""

This commit replaces our custom environment handling implementation with
a port of the better known dotenv project.
It also introduces some breaking changes:

* ntt.env is evaluated before k3.env
* NTT_ prefix has a higher precedence than K3_ prefix
* all variables have to be defined up-front
* all unknown environment variables will be replaced with ""
@5nord 5nord requested review from moosq and 0xmojo August 6, 2021 11:46
@5nord 5nord merged commit 2f63a1d into nokia:master Aug 6, 2021
@5nord 5nord deleted the integrate-env branch August 6, 2021 11:48
5nord added a commit to 5nord/ntt that referenced this pull request Aug 7, 2021
This commit replaces our custom environment handling implementation with
a port of the better known dotenv project.
It also introduces some breaking changes:

* ntt.env is evaluated before k3.env
* NTT_ prefix has a higher precedence than K3_ prefix
* all variables have to be defined up-front
* all unknown environment variables will be replaced with ""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant