Plug the memory leak #128
Merged
Plug the memory leak #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So in my recent testing, there is still a leak but it's definitely gone down by quite a lot. I let this Resources branch run overnight for about 15 hours on very fast UI refresh speed in the processes view and with sorting set to CPU usage during which memory usage rose up to about 600 MB from the starting point of about 90 MB. Current Resources 1.2.1 rose within about 11 hours to over 3 GB with the same settings. |
aeghn
pushed a commit
to aeghn/restop
that referenced
this pull request
Oct 29, 2024
Plug the memory leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources has been suffering from a nasty memory leak for a while now, right now we've at least located where it happens.
It happens during resorting the process and application list after a refresh, especially when many items have changed their position in the list (which happens e. g. when sorting after CPU usage rather than memory usage).
In commit
8d69995, the culprit lines are at src/ui/pages/processes/mod.rs:484 and src/ui/pages/applications/mod.rs:508.Unfortunately, I don't know how to fix it yet, I hope I'll be able to fix it with release 1.3.
Update #1 (2023-12-21): I may have fixed the original memory leak on accident before but introduced another one with right-click context menus. I've removed them again for now and during my testing, this fixed it and memory usage is under control