Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to svelte v5 #376

Closed
wants to merge 30 commits into from
Closed

feat: upgrade to svelte v5 #376

wants to merge 30 commits into from

Conversation

nolanlawson
Copy link
Owner

It's way too early to do this, but I did want to kick the tires on it at least

Copy link

github-actions bot commented Nov 11, 2023

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -1% - +2% (-0.74ms - +1.20ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +7% (-4.59ms - +7.00ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -5% - +7% (-2.44ms - +3.65ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -5% - +2% (-2.24ms - +0.84ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
54.78ms - 56.34ms-unsure 🔍
-1% - +2%
-0.74ms - +1.20ms
tip-of-tree
tip-of-tree
54.76ms - 55.90msunsure 🔍
-2% - +1%
-1.20ms - +0.74ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
102.40ms - 111.00ms-unsure 🔍
-4% - +7%
-4.59ms - +7.00ms
tip-of-tree
tip-of-tree
101.61ms - 109.38msunsure 🔍
-7% - +4%
-7.00ms - +4.59ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
52.29ms - 56.52ms-unsure 🔍
-5% - +7%
-2.44ms - +3.65ms
tip-of-tree
tip-of-tree
51.61ms - 55.99msunsure 🔍
-7% - +4%
-3.65ms - +2.44ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
41.79ms - 43.86ms-unsure 🔍
-5% - +2%
-2.24ms - +0.84ms
tip-of-tree
tip-of-tree
42.38ms - 44.67msunsure 🔍
-2% - +5%
-0.84ms - +2.24ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

github-actions bot commented Nov 11, 2023

Size Change: +7.34 kB (+17%) ⚠️

Total Size: 50.1 kB

Filename Size Change
./bundle.js 50.1 kB +7.34 kB (+17%) ⚠️

compressed-size-action

@nolanlawson
Copy link
Owner Author

I like the idea of snippets, but they don't seem to work yet.

Sadly the bundle size has increased significantly, and the Tachometer tests don't show a significant improvement.

@nolanlawson
Copy link
Owner Author

Got snippets working, got the size down to +15% using hacks.

@nolanlawson
Copy link
Owner Author

Memory usage baseline:

| Scenario | Bytes             | Relative to blank page |
| -------- | ----------------- | ---------------------- |
| blank    | 380 kB (379592)   | 0 B (0)                |
| picker   | 1.23 MB (1228824) | 849 kB (849232)        |
| compact  | 1.11 MB (1108494) | 729 kB (728902)        |
| full     | 1.38 MB (1379992) | 1 MB (1000400)         |

Memory usage:

| Scenario | Bytes             | Relative to blank page |
| -------- | ----------------- | ---------------------- |
| blank    | 380 kB (379572)   | 0 B (0)                |
| picker   | 1.49 MB (1494441) | 1.11 MB (1114869)      |
| compact  | 1.11 MB (1108494) | 729 kB (728922)        |
| full     | 1.37 MB (1366930) | 987 kB (987358)        |

@nolanlawson
Copy link
Owner Author

Hm, sadly Safari 12 support seems broken due to the use of ?. (optional chaining).

Caniuse has Safari 12 usage at around 0.5%, Wikimedia has it at 0.25%.

@nolanlawson
Copy link
Owner Author

Updated memory numbers with Chrome 120:

Baseline:

Scenario Bytes Relative to blank page
blank 388 kB (387700) 0 B (0)
picker 1.23 MB (1228916) 841 kB (841216)
compact 1.11 MB (1108494) 721 kB (720794)
full 1.38 MB (1379992) 992 kB (992292)

This PR:

Scenario Bytes Relative to blank page
blank 380 kB (379572) 0 B (0)
picker 1.5 MB (1495097) 1.12 MB (1115525)
compact 1.11 MB (1108494) 729 kB (728922)
full 1.38 MB (1379992) 1 MB (1000420)

@nolanlawson
Copy link
Owner Author

See #381, I decided to yolo and switch to a custom framework instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant