-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to svelte v5 #376
Conversation
📊 Tachometer Benchmark ResultsSummarybenchmark-total
Resultsemoji-picker-element-change-tab
emoji-picker-element-database-interactions
emoji-picker-element-first-load
emoji-picker-element-search
emoji-picker-element-second-load
|
Size Change: +7.34 kB (+17%) Total Size: 50.1 kB
|
This reverts commit a70518c.
I like the idea of snippets, but they don't seem to work yet. Sadly the bundle size has increased significantly, and the Tachometer tests don't show a significant improvement. |
This reverts commit 449e42f.
Got snippets working, got the size down to +15% using hacks. |
Memory usage baseline:
Memory usage:
|
Hm, sadly Safari 12 support seems broken due to the use of Caniuse has Safari 12 usage at around 0.5%, Wikimedia has it at 0.25%. |
Updated memory numbers with Chrome 120: Baseline:
This PR:
|
See #381, I decided to yolo and switch to a custom framework instead |
It's way too early to do this, but I did want to kick the tires on it at least