-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browserify-specific fix for #29 #36
Conversation
…dds ability to wrap functions that are elements of an array literal in an argument list
…ack patterns rather than all array literal function parameters.
…e from walk-ast to estree-walker
…-ast to estree-walker
This looks fantastic! One thing I was momentarily confused on was:
I thought this referred to Browserify with the BTW just a quick remark that these PRs are incredibly thorough and well-written, and I'm extremely grateful that you're improving my little weekend project so much. 🙇 optimize-js is suddenly turning into a very nice general-purpose tool! |
Aw shucks, my pleasure. Thanks for accepting the PRs! |
It seems this update is not included in the release v1.0.2 yet. (not avail via npm neither) PS: I tried it on a large browserify project and I had HUGE improvements!! Great work! |
I'm going to work on a large rewrite of the benchmarks to include better stats, and then re-run them to ensure there are no regressions. Unfortunately I've been swamped, hence why this has sat for so long. |
Fix for #29, trying to optimize browserify modules, in a very specific way.
This fix will optimize function expressions that are:
Added both positive and negative test cases. I did some basic testing against the PouchDB benchmark, and this PR makes it a lot faster.