Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#37) - update benchmarks to more accurately include compilation time #46

Merged
merged 0 commits into from
Jan 5, 2017

Conversation

nolanlawson
Copy link
Owner

Fixes #37.

Lots of changes in this PR, mostly revolving around improving the accuracy of the benchmarks and preparing us for a 1.0.3 release.

The good news is that optimize-js still provides a measurable benefit in Chrome, Firefox, and Edge. The bad news is that I can confirm Safari is a slight regression (~-1%), and with the new, more accurate benchmarks, we can only boast more modest improvements in various browsers (~20% in Chrome rather than ~57%).

Since my goal with optimize-js is more to provide research than to provide the tool itself, though, I'm happy to just report the data as I find it. Also there's nothing to stop us from continuing to test, continuing to tweak, and continuing to improve. 😃

Major changes in this PR

  • More accurate perf measurements using marky and as described in Benchmark unfairly excludes compilation time. #37 (comment)
  • Drop Ember from the benchmark – it was causing the browser to crash due to a memory leak, and its reliance on jQuery made it hard to work with
  • New bin/print-bundle-sizes.sh script to more easily generate these for the README
  • Automatically delete added window keys between each test, delete scripts after use to reduce memory overhead
  • Update Lodash and PouchDB libraries to latest of each

@nolanlawson nolanlawson merged commit c8ddc67 into master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant