Parse E2E flags/configs with AST instead of RegExps #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
force-pushed
the
e2e-with-ast
branch
2 times, most recently
from
c6c994c
to
c08c9b9
Compare
nolar
force-pushed
the
e2e-with-ast
branch
2 times, most recently
from
c0590d3
to
7098b1c
Compare
Parsing the AST allows us to have multi-line E2E-configs (e.g. lists), enriched with comments where needed. RegExps are limited to simple one-line values, and this does not fit into 100 chars limit sometimes. Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing the AST allows us to have multi-line E2E-configs (e.g. lists), enriched with comments where needed. RegExps are limited to simple one-line values, and this does not fit into 100 chars limit sometimes.