Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bi-directional-links): incorrect token implementation and dup handling for .png images #239

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

nekomeowww
Copy link
Member

@nekomeowww nekomeowww commented Jun 18, 2024

Summary

incorrect token implementation

Token push here

const innerTextToken = state.push('text', '', 0)

will result unintended extra text instead of alt text.

dup handling for .png images

Due to the loop of


and the duplicated .png over

All the .png images will be processed twice and get mis-repect as duplicated name then fallback to absolute path matching strategy.

…dling for .png images

Signed-off-by: Neko Ayaka <neko@ayaka.moe>
@nekomeowww nekomeowww added bug Something isn't working pkg/bi-directional-links Related to @nolebase/markdown-it-bi-directional-links labels Jun 18, 2024
@nekomeowww nekomeowww merged commit c450ff8 into main Jun 18, 2024
6 checks passed
@nekomeowww nekomeowww deleted the dev/bi-directional-links-fix-image branch June 18, 2024 16:37
Copy link

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://6671b8cfab5bad133e7b0253--nolebase-integrations.netlify.app
Windows Success https://6671b8d8803efa136cdbfc08--nolebase-integrations.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg/bi-directional-links Related to @nolebase/markdown-it-bi-directional-links
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant