fix(bi-directional-links): incorrect token implementation and dup handling for .png
images
#239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
incorrect token implementation
Token push here
integrations/packages/markdown-it-bi-directional-links/src/utils.ts
Line 90 in 9ccd96b
will result unintended extra text instead of alt text.
dup handling for
.png
imagesDue to the loop of
integrations/packages/markdown-it-bi-directional-links/src/index.ts
Line 192 in 9ccd96b
and the duplicated
.png
overintegrations/packages/markdown-it-bi-directional-links/src/index.ts
Line 32 in 9ccd96b
All the
.png
images will be processed twice and get mis-repect as duplicated name then fallback to absolute path matching strategy.