Fixed x86_64 detection #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prints detected architecture to console
Simplified code for busybox installation Made detected-architecture log more readable
Various if statements were not written properly refer to https://stackoverflow.com/questions/53974739/my-string-comparisons-always-evaluate-to-true/53974758#53974758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary issue was that the if statements were not evaluating correctly. Fixing the syntax, fixed the bug.
I also added some logging to ensure everything is working properly. Some are not entirely necessary, but may prove useful for later bug testing
Resolves:
#17
Possibly Resolves:
#6
#14
#15