Naming: device_token instead of device

[dennisreimann]

Hello Mattt,

what do you think about changing the name of the device variable/parameter in the notification class to device_token? I think this would make it a bit clearer, especially in the context of using houston along with rack-push-notification. I just tripped over this, passing a device instance into the notification initializer, instead of giving it the device.token (which works, but will fail silently later on)

It's not a very big deal but imho this would make the notifications interface clearer. I know this would be a breaking change, but I think it's worth considering, because even without the rack-push-notification context this could make it more intuitive.

Cheers!

[mattt]

I think you're absolutely right. Everywhere in the code except for the instance variable, it's referred to as a token, so the one-off is confusing. 926590c renames device to token while maintaining backwards compatibility. Thanks for your recommendation!

[dennisreimann]

Awesome, thanks! 🍰

[dennisreimann]

One more thing: Can you push a new version with this change, or are you planing to integrate some more stuff into 0.2.2?

[mattt]

Just pushed 0.2.2. Enjoy!

[dennisreimann]

\o/ :cake: