Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#4): Open Source - release #7

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

Alberdi
Copy link
Member

@Alberdi Alberdi commented Jan 11, 2024

  • Added Apache LICENSE, README and CONTRIBUTING.
  • Updated the tests to 100% coverage and added xref and dialyzer checks.
  • Removed unused nbully_debug module.
  • Other minor esthetic changes.

Closes #4.

* Added Apache LICENSE, README and CONTRIBUTING.
* Updated the tests to 100% coverage and added xref and dialyzer checks.
* Removed unused nbully_debug module.
* Other minor esthetic changes.

Closes #4.
@Alberdi Alberdi added the enhancement New feature or request label Jan 11, 2024
Copy link
Member

@javiergarea javiergarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Nitpick: I would not enforce coverage at 100%, but won't block open source releases becase of it 😆

src/nbully.app.src Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Alberdi Alberdi force-pushed the feature/4-open-source-release branch from 5a7d69b to d199a12 Compare January 11, 2024 14:18
@Alberdi
Copy link
Member Author

Alberdi commented Jan 11, 2024

I downgraded the coverage expectation to 95% because in Erlang 25 the peer module doesn't mark as covered some of the calls done by the new nodes (maybe due to erlang/otp@d7f1801).

There are still some (previous) flakiness issues with the tests, but I will try to review them at a later date.

@Alberdi Alberdi merged commit 71b38c3 into main Jan 12, 2024
2 checks passed
@Alberdi Alberdi deleted the feature/4-open-source-release branch January 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Source - release
3 participants