-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme for menus #2578
Update theme for menus #2578
Conversation
Signed-off-by: 3simplex <10260755+3Simplex@users.noreply.github.com>
Signed-off-by: 3simplex <10260755+3Simplex@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can combine into these three colors and then use them in the model combobox in ChatView.qml, the context menus, AND the popup in MyComboBox?
gpt4all-chat/qml/Theme.qml
Outdated
@@ -1164,6 +1164,50 @@ QtObject { | |||
} | |||
} | |||
|
|||
property color chatViewModelListFrameColor: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could just be MenuFrameColor ?
gpt4all-chat/qml/Theme.qml
Outdated
} | ||
} | ||
|
||
property color chatViewModelListBgColor: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MenuBackgroundColor?
Signed-off-by: 3simplex <10260755+3Simplex@users.noreply.github.com>
Signed-off-by: 3simplex <10260755+3Simplex@users.noreply.github.com>
The background within the settings menu has been reverted to its original state. (no more big box behind the settings) |
This is fine by me, but asking our design guy Vincent to have a look to sign off or suggest another workaround |
Signed-off-by: 3simplex <10260755+3Simplex@users.noreply.github.com>
Worked directly with Vincent, updated code for requested changes.
|
Signed-off-by: 3simplex <10260755+3Simplex@users.noreply.github.com>
Signed-off-by: 3simplex <10260755+3Simplex@users.noreply.github.com>
Signed-off-by: 3simplex <10260755+3Simplex@users.noreply.github.com>
Thank you @3Simplex !! Really cool work |
Describe your changes
Menu theme colors adjusted to produce softer look while maintaining current scheme.
To achieve this:
Assigned property names for each color by the object to which they apply. (Ideally easy to understand without needing to trace)
Other:
Issue ticket number and link
Checklist before requesting a review
Demo
Steps to Reproduce
Notes
Summary:
Updated theme colors for menus and context menus with new color properties for a softer look in
gpt4all-chat/qml/ChatView.qml
,gpt4all-chat/qml/MyMenu.qml
, andgpt4all-chat/qml/MyMenuItem.qml
.Key points:
gpt4all-chat/qml/ChatView.qml
,gpt4all-chat/qml/MyMenu.qml
, andgpt4all-chat/qml/MyMenuItem.qml
.gpt4all-chat/qml/Theme.qml
:chatViewModelListFrameColor
chatViewModelListBgColor
chatViewModelListHighlightColor
contextMenuFrameColor
contextMenuBgColor
contextMenuHighlightColor
Generated with ❤️ by ellipsis.dev